vBulletin Mods

The Official vBulletin Modifications Site
https://www.vbulletin.org/forum/showthread.php?t=286107

Bug when quoting members with "[" or "]" in their nicknames
by chefy
30 Jul 2012 15:43

1 Attachment(s)
We will use for this example a random member: [Dx]. So imagine that you're quoting a post from [Dx] then the quote code should look like this:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

However it's being parsed as this:

http://www.vbulletin.org/forum/attac...1&d=1343662839

Breaking the quote tag.

Please fix this at vB.org and also share with us the instructions so we all the users of vB 3.x will be able to apply the fix in our own forums.

chefy 31 Jul 2012 17:20

I can confirm that this bug is also present in vB 4.2

Ziki 31 Jul 2012 18:29

Nice catch :)

Also install quote notifications on vb.org!

Paul M 31 Jul 2012 19:52

The fix is not to allow [ or ] in usernames.

Its bound to clash with any BB code, not just quote, and would be very difficult to do anything about.

Simon Lloyd 31 Jul 2012 22:01

If you must allow daft characters in the usernames you'll have to work out a way of encapsulating it in [noparse]

DivisionByZero 01 Aug 2012 22:14

i got sick of names like |< () R |\| and other crap a LONG time ago and disabled all but letters, numbers, underscores and dashes.

Sarteck 02 Aug 2012 10:43

I don't think it's too unreasonable to consider utilizing a method where square brackets would be acceptable in a BB Code's option, myself.

For example, enclosing the option in quotes or double-quotes to represent literal brackets rather than to-be-parsed brackets.

[QUOTE="[Sarteck]"]Lorem Ispum[/QUOTE]

This actually works, btw, already, when quote does not have a second parameter delimited by a semi-colon.

Quote:

Originally Posted by [Sarteck]
Lorem Ispum

The problem only exists when the second parameter exists. E.G.



[QUOTE="[Paul M]";2353120]The fix is not to allow [ or ] in usernames.[/QUOTE][/noparse][/B]

yields
[QUOTE="[Paul M]";2353120]The fix is not to allow [ or ] in usernames.[/QUOTE]






[/QUOTE][/QUOTE][/QUOTE]Anyways, to sum it up.... I disagree with the statement that the "fix" is to not allow brackets in usernames. I think the "fix" would be to fix the problem. ;)




[SIZE=1][COLOR="Silver"]--------------- Added [DATE]1343906114[/DATE] at [TIME]1343906114[/TIME] ---------------[/COLOR][/SIZE]





[QUOTE=Sarteck;2353596]My Rambling[/QUOTE]

Ah. Seems that if the [B]entire option[/B] is enclosed with quotes, everything goes smoothly.

E.G.:
[B][noparse][QUOTE="[Sarteck];2353596"]My Rambling[/QUOTE]




Quote:

Originally Posted by [Sarteck] (Post 2353596)
My Rambling

:3


So, just have the Quote thingamabob enclose the stuff in quotes, yeah?

--------------- Added 02 Aug 2012 at 12:27 ---------------

---------------

Aaaaaand, problem solved on vB4 if you change the newpost_quote template.


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


I don't know if vB3 (for vB.org) would have the same solution or not.

Paul M 02 Aug 2012 14:10

vb.org doesnt allow such usernames, so its not an issue.

chefy 02 Aug 2012 15:28

But could you share a fix like the one posted by Starteck for vB 3.8 users please?

BirdOPrey5 02 Aug 2012 21:58

vBulletin 3.x has a newpost_quote template too.

You could try changing it from:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

No idea if it will work.

I agree with Paul the better option is not to allow such usernames- unable to predict what else they may break in the future.

Paul M 03 Aug 2012 00:45

Quote:

Originally Posted by chefy (Post 2353685)
But could you share a fix like the one posted by Starteck for vB 3.8 users please?

We cannot share what we do not have. :cool:

vbenhancer 03 Aug 2012 21:53

Quote:

Originally Posted by Paul M (Post 2353851)
We cannot share what we do not have. :cool:

i think he mean we find a solution for his own personal situation... basically, Shefi, you can post a unpaid request for this situation... maybe someone will get you a fix!

Ziki 04 Aug 2012 12:28

Quote:

Originally Posted by Paul M (Post 2353851)
We cannot share what we do not have. :cool:

What about quote notifications? I think it would be nice if every member had an option in his usercp to choose whether he wants to be notified via PM or e-mail if he's been quoted here by another member ;)

Paul M 04 Aug 2012 14:43

Not sure how that is related to usernames, bbcode or my comment :confused:

Ziki 04 Aug 2012 17:53

Well since we were talking about quoting and stuff....and I didn't feel like starting a new thread if I was to get shot down right away :D so is it a no or a yes?


All times are GMT. The time now is 01:08.

Powered by vBulletin® Version 3.8.14
Copyright © 2020, MH Sub I, LLC dba vBulletin. All Rights Reserved. vBulletin® is a registered trademark of MH Sub I, LLC
Copyright ©2001 - , vbulletin.org. All rights reserved.