vBulletin Mods

The Official vBulletin Modifications Site
https://www.vbulletin.org/forum/showthread.php?t=327747

Anyway to detect current page in template?
by ShikiSuen
03 Jan 2020 09:57

I want to let a template detect whether current page is "forumdisplay" or "index".

PinkMilk 03 Jan 2020 18:27


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Change to desired page showthread, forumdisplay etc

ShikiSuen 04 Jan 2020 11:16

Quote:

Originally Posted by PinkMilk (Post 2601658)
Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Change to desired page showthread, forumdisplay etc


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

I single-quoted the THIS_SCRIPT but looks like this renders it ineffective.

P.S.: I already tried this trick prior to creating this thread here. Wondering whether I messed up with something else. My board runs on PHP 7.4 .

------------

Update: Similar issue happens with MyBB:
https://github.com/mybb/mybb/issues/3017
https://github.com/mybb/mybb/pull/3092

Looks like some php files in the 'includes' folder needs modification to declare the "THIS_SCRIPT".
------------

Following-up: This warning can be dismissed. It won't cause template rendering error as it does not generate any similar error message in forumdisplay, index, etc. These php files already have "THIS_SCRIPT" defined. My conclusing is that the template system of vBulletin 3.8.11 needs some fix.

Solution: Editing "template.php" and add the following to "DEFINE IMPORTANT CONSTANTS":


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Otherwise, PinkMilk's trick won't work if vBulletin 3.8.x runs on PHP 8 in the future.

lange 04 Jan 2020 12:04

Quote:

Originally Posted by ShikiSuen (Post 2601664)
Solution: Editing "template.php" and add the following to "DEFINE IMPORTANT CONSTANTS":


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Your fix works fine for me. Thank you very much !

I had the same warning in the Navbar template for the responsive style of Sultantheme :
Quote:

PHP Warning: Use of undefined constant THIS_SCRIPT - assumed 'THIS_SCRIPT' (this will throw an Error in a future version of PHP) in ..../includes/adminfunctions_template.php(3959) : eval()'d code on line 525

PinkMilk 04 Jan 2020 19:00

I'm running php 5.6.32 on my local vb version so probably can't recreate the error if you think its higher php related,

HOWEVER...
I noticed I missed the closing " (previous post fixed).


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.



All times are GMT. The time now is 18:56.

Powered by vBulletin® Version 3.8.14
Copyright © 2020, MH Sub I, LLC dba vBulletin. All Rights Reserved. vBulletin® is a registered trademark of MH Sub I, LLC
Copyright ©2001 - , vbulletin.org. All rights reserved.