[G-Force 199]

Installed.
Thank you

[wholemama]

First and foremost...THANK YOU!!!

*****************************

I'm getting an error when we try to call the search function (as in when we click New Posts)...

Fatal error: Call to undefined function: private_thread_not_allowed() in /.../search.php on line 1823

Same happens in the other instantiation of the function on line 2224. Commented those out for now

****************************

The product doesn't seem to create the 'allowprivate' field...added that manually to the DB and then manually adjusted it as needed for my interim solution

***************************

When I try to edit a thread, I get...

Parse error: parse error, unexpected $ in /.../postings.php on line 2327

In the second portion of code added to postings.php, it's missing the closing } for the if statement

******************************

When I edit a thread that's been private...if I had more than one name saved originally in the allowed/denied list, when it pulls them back in, it only brings back the first name in the list.

[Eikinskjaldi]

That's unexpected behavior, and I have it running just fine on my main board and test board. I'll install it on my test board again tonight and get back to you on the results of further testing.

It's still in beta and I have some improvements ready for it, too.

[waza]

Does it has usergroup permissions?
And can't you do it with less file edits (by replacing them with plugins.)
However, It sure looks good!

[Eikinskjaldi]

Bleh, my first release and I mess up stuff as simple as copying and pasting. Sorry about that :nervous:

I've updated to v1.0.5 and fixed the problems (works flawlessly when installed on my test board), added to the product, and added a new plugin to it.

@waza: What do you mean by usergroup permissions? You can allow or restrict viewing by usergroup, if that's what you mean.

I've tried to limit file edits to the best of my ability. I've only been on vB3.5 for a week, and just learning the new data management was daunting enough. If I can find other ways, or if anyone else can find other ways, to avoid file edits and maximize plugin use, the hack will be updated for that.

[waza]

No what I mean is if you can restrict usergroups who can post private threads.
However, I looked @ the zip, and as there aren't any bitfield xml's their wont be usergroup permissions.
Like here:
http://www.vbulletin.org/forum/showthread.php?t=82844

And I'm sure a lot of file edits can be done by plugins, If I find some time I try to make use of plugins and pm them.

[buro9]

Perfect!

You wouldn't believe the need I have for this. It's incredibly sensitive, and this is a life saver.

Thank you so much for making and publishing it.

[rnmcd]

Thanks.

Looks like you finished before this:
http://www.vbulletin.org/forum/showthread.php?t=80135

[XanTrax]

From the types of people I deal with in my forums this would be abused 10 thousand times over. If anything try to add an option for which usergroups or users are allowed/not allowed to use this option. Something like...

Can user select thread options: Yes / No

[wholemama]

That version fixes everything!

And I figured out the multiple users thing...I was doing what was intuitive and putting a space after the semi-colon like a list...but no space can go there. So I'm altering the template to put a warning about that for my users (who aren't the most computer literate sometimes!).

The only problem that's keeping me from making this live now...when the thread shows in the Last Post column and you click on it, you can see it no matter if you're supposed to or not. It's like that call doesn't check the private_thread_not_allowed().

[Eikinskjaldi]

Future Plans: Private Threads will NOT show in the lastpost column when user does not have access to thread

I'm hoping to have that changed soon. I still need to find out how to make it check for the next available "last thread" after that, and then repeat the permissions check, and loop until it finds one the person does have permission to.

[buro9]

I think you missed out something like:

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

in the showthread.php file, and then change $restrictedusers to $threadinfo[privateusers] in the showthread template.

And I've made it admin only, by doing things like the following in the newthread and the edit thread templates:

<if condition="$foruminfo['allowprivate'] == 1 and is_member_of($bbuserinfo, 6)">

Where 6 is the id of the Admins usergroup

[wholemama]

Originally Posted by Eikinskjaldi

I'm hoping to have that changed soon. I still need to find out how to make it check for the next available "last thread" after that, and then repeat the permissions check, and loop until it finds one the person does have permission to.

Yup...

I don't mind it showing in the Last Post column...that doesn't matter at all...it's just that it needs to check it when you load from that link (or any other direct link).

[wholemama]

Ok...got that working...that was my error!

Happy happy joy joy!