[DragonByte Tech]

That should be fine. I'll let you know how I get on chasing the bug over the weekend and send you a message if I need to test a few things.

Matt

[katie hunter]

Originally Posted by DragonByte Tech

I'll try and look over what might be causing the missing images, I'm slightly puzzled by it. If possible, could you check what the exact broken link is to the image and post it here?

I will take a look at trying to implement your ideas when we do our big update on vBDonate which is due soon. I'm currently working on getting the v2 of the DBTech Classifieds ready and then I'll be concentrating on vBDonate.

@Barbeque_Eater, thanks for the headsup. I'll take a look and see what might be causing the issue. So far I've not been able to replicate this bug myself, but that info might just help me. It may be that I need to test somethings on your install, would that be possible?

Matt

Hi Matt, it simply doesn't link to the image extension, so like this

http://vb4.domain.net/dbtech/vbdonate/images/admin/

instead of ex

http://vb4.domain.net/dbtech/vbdonat...mnt%20sett.png

[Shanakar]

I was wondering if it was possible for you to add an option to the Donation Goals. Right now it has Month and Year. Is there any way to add another option called Project? I would like my users to be able to donate towards projects that they want to be made rather than the monthly, yearly options. Any way to do this please?

[DragonByte Tech]

Originally Posted by katie hunter

Hi Matt, it simply doesn't link to the image extension, so like this

http://vb4.domain.net/dbtech/vbdonate/images/admin/

instead of ex

http://vb4.domain.net/dbtech/vbdonat...mnt%20sett.png

I've found what was causing the problem. The options were being displayed from the Pro version that shouldn't exist in the Lite. I've fixed that for the next update.

Originally Posted by Shanakar

I was wondering if it was possible for you to add an option to the Donation Goals. Right now it has Month and Year. Is there any way to add another option called Project? I would like my users to be able to donate towards projects that they want to be made rather than the monthly, yearly options. Any way to do this please?

I was thinking of something similar. We'll see what we can do with that for v2.

@Barbecue_Eater: I'm still tracing that issue I can't replicate it exactly. Is it possible to test whether you still have the same issue if you use English as the main language if possible? My gut feeling is that the issue is connected to the language somehow.

The only other suggestion I have to try for now (pending some input from Fillip @DBTech) is that you redownload the latest vB4 files and reupload them in case there was something in the way the GPC works that has been accidentally corrupted.

Matt

[Barbecue_Eater]

Originally Posted by DragonByte Tech

@Barbecue_Eater: I'm still tracing that issue I can't replicate it exactly. Is it possible to test whether you still have the same issue if you use English as the main language if possible? My gut feeling is that the issue is connected to the language somehow.

The only other suggestion I have to try for now (pending some input from Fillip @DBTech) is that you redownload the latest vB4 files and reupload them in case there was something in the way the GPC works that has been accidentally corrupted.

Matt

Thanks so far.
Which exact language setting are we talking about here?
I'll probably have to download the english language xml, we only have the German one.

I'm pretty sure there is nothing broken about the files, I remember having the bug before upgrading to the newer version (4.2.1 > 4.2.2).


EDIT:
By setting the language to English (US), the problem is resolved.
How do I fix it with the German language?

It's probably because of the decimal separator.
In the US, you use

.

as a decimal separator - here in middle EU you use

,

The same applies to the thousand separator: you're using

,

while we're using

.

But the code needs to be changed in order for the plugin to work properly.

.
.
.
.
-- EDIT 2: Our fix that we use from now:

I fixed it by changing Line 26 of dbtech\vbdonate\includes\functions.php to

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

and started separating the amounts by the character "/" in the vBDonate settings and using a comma instead a dot as the decimal character.

This will not work for the english language pack though, therefore I suggest you guys implement an automatic parser that converts the amounts to the correlating decimal systems of the language. There is a vbulletin variable that can read the decimal character, you can use that automatically based on the users language setting.

Regards.

[DragonByte Tech]

Originally Posted by Barbecue_Eater

Thanks so far.
Which exact language setting are we talking about here?
I'll probably have to download the english language xml, we only have the German one.

I'm pretty sure there is nothing broken about the files, I remember having the bug before upgrading to the newer version (4.2.1 > 4.2.2).


EDIT:
By setting the language to English (US), the problem is resolved.
How do I fix it with the German language?

It's probably because of the decimal separator.
In the US, you use as a decimal separator - here in middle EU you use


The same applies to the thousand separator: you're using while we're using

But the code needs to be changed in order for the plugin to work properly.

.
.
.
.
-- EDIT 2: Our fix that we use from now:

I fixed it by changing Line 26 of dbtech\vbdonate\includes\functions.php to

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

and started separating the amounts by the character "/" in the vBDonate settings and using a comma instead a dot as the decimal character.

This will not work for the english language pack though, therefore I suggest you guys implement an automatic parser that converts the amounts to the correlating decimal systems of the language. There is a vbulletin variable that can read the decimal character, you can use that automatically based on the users language setting.

Regards.

That's an interesting fix to the problem, I was going to post that it might be the issue. I'll see if I can work forward with that idea.

We have found with several things that the language decimals/separators are usually the issue. Changing the settings in the main options seems to work better than using the language separators.

I'll see if I can work a permanent fix in for you.

Matt

[Maniac199]

I know many of you have asked for this so here is a widget I made that will show the username, date, and amount of the last 10 donations. You can feel free to modify, use, and do whatever you want with this code. Make it as a PHP direct execution.

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

[Barbecue_Eater]

Though we fixed the comma at the point I told you, the system didn't recognize the money that was contributed.

Just a question in general: About when can we count for the new version?

[DragonByte Tech]

Originally Posted by Barbecue_Eater

Though we fixed the comma at the point I told you, the system didn't recognize the money that was contributed.

Just a question in general: About when can we count for the new version?

What do you mean about it not recognizing? If you can elaborate today I might be able to get the fix out tomorrow. I'm working on it atm in the spare time I get between Classifieds and work.

Matt

[Barbecue_Eater]

I mean: Using the German language pack - no matter what way you donate, it doesn't show up in the added contributions list and also not in the overall contribution amount of the donation bar.
So for example my donation goal is 100€, I can donate any amount I want, it will not come any closer to the goal.
The sandbox mode is not activated.

Also, the custom amount doesn't work with the commas, showing an error which states that the entered amount is not a number if I have a comma in it. There must be some other part of a script responsible for stripping the custom amount as well.

Don't you have a development version of vBulletin anywhere that you can simply drop the language pack on and see yourself?

[DragonByte Tech]

I'm taking a look at this now to see if I can trace a solution. There have always been problems in the way the language packs pass settings of customized numbers back to scripts.

I've an idea on how we can permanently resolve the issue in v2 which will have to wait until then as it will require some of the additions/changes we plan on implementing. In the mean time, if you can, test it by clearing the language settings for your German pack. If that passes the variable correctly, it is the language pack that is definitely causing the issue. If not, then it's something else.

I've got a Spanish pack installed I used for testing the Classifieds money settings on which I'll have a play around with now. How I fixed it for Classifieds requires the changes I mentioned above for vBDonate.

Matt

[DragonByte Tech]

Having looked at this, I think I have a solution. I've tested this as far as I can (On my dev install I can't go beyond the PayPal payment section).

I've created a setting now that let's you choose your separator for the values and the system checks that. My tests show fine. It's my guess that your contributions are going into the 'unconfirmed' section in your tests.

Once I've marked it as confirmed the correct amount is added to the banner.

Let me know if you want to give the code a test as per the PM I sent you and we can see if we've got a fix for you.

Matt

[DragonByte Tech]

Hi everyone,

An update for vBDonate (1.4.7) includes some bug fixes as well as a new setting aimed at improving support for other languages. It had been problematic trying to create values if the language you had on your site used a comma ',' for the decimal point (separator), i.e. 20,00 instead of 20.00. Now it's possible to use the comma as the decimal point and change the separator we use for the amounts available to users to pick from. Before the amounts needed to be listed like 5.00,10.00,15.00. But with the Amount Separator setting you can choose to use another character such as '/' allowing users who need the comma for their decimal point to be able to do so. Several of the fixes also improved the formatting of the currency values for other languages, something we will be continuing to expand as we move towards version 2 of vBDonate.

Lite version is available here, vBDonate DragonByte Tech - vBulletin Mods & Addons or here vBulletin.org. The Pro version is available in your Customer Area if you have purchased a license and it is still valid.

If you like the product you can show your support by nominating it for mod of the month here, vBDonate Donations - Donate Manager - vBulletin.org Forum and also please rate it to help cancel out the users who 1 star our mods.

A full changelog is below:

Bug Fixes And Issue Fixes:
Fixed: Bad image links in the Lite version Admin Dashboard area
Fixed: Number formatting for total amount received on the main donation bar
Fixed: Redirect Error when returning from PayPal
Fixed: Incorrect links in one phrase

Additions To Product From Feature Requests Or Just Something Else Added:
Feature: Setting to allow for changing the the amount separator for values that can be donated to allow for using a comma ',' as a decimal separator for various languages in the language settings

Matt

[kamran_dotnet]

any plan for add new feature to use local vbulletin payment api?
you already done this in db AD

[DragonByte Tech]

We've got a few plans to expand things like that, yes.

Matt