Register Members List Search Today's Posts Mark Forums Read

 
 
Mod Options
  #1  
Old 30 Aug 2011, 20:32
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
MrZeropage Can you step in please

MrZeropage once again thanks for providing this mod to everyone here (we all luv it)
The biggest issue ATM with the newest vb and the ibproarcade is the holdsession.php stopped working .. you need to have the remember me ticked or you get logged out of the forum when going to play a game.... so , you are playing the game then finish and submit your score your logged out..
or if you click on a game and then try to View High Scores your logged out


a fix for this would be greatly appreciated..By everyone that uses this mod
Regards
Ron
Comments
  #2  
Old 30 Aug 2011, 21:27
Mark.B Mark.B is offline
 
Join Date: Feb 2004
Hmm just done some playing with this...didn't even know it was an issue since my board has always had the box ticked by default.

Anyway....try changing that "echo" line to this:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


That seems to be working for me, whereas I was able to replicate the issue before by unticking the box.

Certainly the syntax was all wrong before.
  #3  
Old 30 Aug 2011, 21:45
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
thanks Mark I will test it out ..

as mine has always been ticked by default as well.. but I am looking to improve it for others..
Peek in this forum, I been helping out for some time, I was determined to keep this mod alive..
I will report back..


thanks
Hippy

--------------- Added 30 Aug 2011 at 21:53 ---------------

Just checked my notes I have tried this after tons of research this does work..

but it fills your apache error log file up with this error..


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

thanks for your effort
  #4  
Old 30 Aug 2011, 21:59
Mark.B Mark.B is offline
 
Join Date: Feb 2004
Originally Posted by Hippy View Post
thanks Mark I will test it out ..

as mine has always been ticked by default as well.. but I am looking to improve it for others..
Peek in this forum, I been helping out for some time, I was determined to keep this mod alive..
I will report back..


thanks
Hippy

--------------- Added 30 Aug 2011 at 21:53 ---------------

Just checked my notes I have tried this after tons of research this does work..

but it fills your apache error log file up with this error..


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

thanks for your effort
Hmm I had a feeling that might happen because actually the syntax is still wrong...it's going to get confused with the ' marks.

But it seems to work...whereas correcting the syntax like this:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

fails!

--------------- Added 30 Aug 2011 at 22:04 ---------------

Well I reversed the syntax as well to this:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

And it still fails.

Syntactically (is that a real word?) it's correct so I can't fathom what's making it fail.

Last edited by Mark.B; 30 Aug 2011 at 22:05.
  #5  
Old 30 Aug 2011, 22:53
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
I pulled my hair out on this pal..
I read and got it working and I was happy !
till 500 email came with this apache error

LoL I don't know if it's a real word or not lol (sounds good to me tho )I'm not an expert so I read and came up with what you posted and it worked but like I said those errors where killing me ..
  #6  
Old 31 Aug 2011, 06:46
MrZeropage's Avatar
MrZeropage MrZeropage is offline
 
Join Date: Nov 2003
Real name: Marcel
I started the v2.7.2+ development and will implement all fixes that have been found, will also check the holdsession.php

First need to install fresh vB4 on my site, this is my task for the weekend
__________________
Get the most installed modification for your vBulletin (more than 8400 installations and 148.000 downloads!):
ibProArcade 2.7.6+ download here | Click here to enter the ibProArcade-Support-Section
Don't miss the new Google Analytics Integration (GDPR/DSGVO) for vB4.x
  #7  
Old 31 Aug 2011, 08:17
Eric's Avatar
Eric Eric is offline
 
Join Date: May 2006
Real name: Eric
Shouldn't it be:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

That should work.
__________________
My modifications

Please do not contact me for support via PM or E-Mail unless I've asked you to do so. Otherwise, your message will be ignored/deleted.
  #8  
Old 31 Aug 2011, 16:24
waylandprod's Avatar
waylandprod waylandprod is offline
 
Join Date: Jan 2011
I had one of my more tech-savvy users look at it, and he fixed it by changing the php in 'holdsession.php' from

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

AND changing

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


Last edited by waylandprod; 31 Aug 2011 at 16:29.
  #9  
Old 31 Aug 2011, 19:46
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
Originally Posted by Eric View Post
Shouldn't it be:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

That should work.
Originally Posted by waylandprod View Post
I had one of my more tech-savvy users look at it, and he fixed it by changing the php in 'holdsession.php' from

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

AND changing

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.
thanks for your efforts guys..

that change does hold the session but
now this is the error in the apache error log

PHP Parse error: syntax error, unexpected T_OBJECT_OPERATOR in /forum/holdsession.php on line 19,
witch is this line now

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

  #10  
Old 31 Aug 2011, 19:58
Mark.B Mark.B is offline
 
Join Date: Feb 2004
Originally Posted by Hippy View Post
thanks for your efforts guys..

that change does hold the session but
now this is the error in the apache error log

PHP Parse error: syntax error, unexpected T_OBJECT_OPERATOR in /forum/holdsession.php on line 19,
witch is this line now

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.
Surely that should be:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Also I'm certain the echo should be:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Otherwise why set $session['sessionurl_q] and append the "?" in the first place?

Driving me bonkers this!

Last edited by Mark.B; 31 Aug 2011 at 20:29.
  #11  
Old 31 Aug 2011, 20:46
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
Same apache error
this has become a problem since I believe 4.0.8
I have no idea what changed but

thanks for keeping up with this issue
  #12  
Old 31 Aug 2011, 20:54
Mark.B Mark.B is offline
 
Join Date: Feb 2004
Originally Posted by Hippy View Post
Same apache error
this has become a problem since I believe 4.0.8
I have no idea what changed but

thanks for keeping up with this issue
Remembering the php college course I did a few years back now, where they set us very similar "problems" to this to solve at home, I am convinced we still have an issue with the ' marks everywhere, and which should be escaped and which not.

I *think* we have the echo line correct now but there is probably still an issue with this:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

  #13  
Old 31 Aug 2011, 21:00
Eric's Avatar
Eric Eric is offline
 
Join Date: May 2006
Real name: Eric
Try the attached file.
Attached Files
File Type: php holdsession.php (1.3 KB, 4 views)
__________________
My modifications

Please do not contact me for support via PM or E-Mail unless I've asked you to do so. Otherwise, your message will be ignored/deleted.
  #14  
Old 31 Aug 2011, 21:34
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
Originally Posted by Eric View Post
Try the attached file.
no errors in the log but you get logged out of the board..
thanks for your effort

This is getting to me like it did last time..

I am sure it now boggling everyone in the thread

--------------- Added 31 Aug 2011 at 21:43 ---------------

for shits and giggles I uploaded a blank holdsession.php

no errors in the apache logs.. and you don't get logged out ... w t f

I don't get this

But f it's a long game I'm not sure if you would be logged out ..
I only test on a short game I don't have the time to sit ATM and play a longer game..

or if it's like this maybe someone would be able to cheat ..

I'm so confused..
maybe all the code you guys posted is good maybe it's how the arcade.php is handling it ??
 

Similar Mod
Mod Developer Type Replies Last Post
Mini Mods Use Google Custom Search In Navbar - Step By Step rajubd vBulletin 4.x Template Modifications 104 29 Jul 2017 14:43



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Mod Options

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 00:56.

Layout Options | Width: Wide Color: